From 8b8e97bb5bceb52d42d2aa339ab44f082035d5b9 Mon Sep 17 00:00:00 2001 From: "emellor@leeni.uk.xensource.com" Date: Tue, 23 May 2006 16:14:03 +0100 Subject: [PATCH] Fix xspy_get_permissions -- you can't increment the perms pointer when iterating and expect to be able to free that pointer afterwards. Signed-off-by: Ewan Mellor --- tools/python/xen/lowlevel/xs/xs.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/tools/python/xen/lowlevel/xs/xs.c b/tools/python/xen/lowlevel/xs/xs.c index c900c5ed51..348e1fe656 100644 --- a/tools/python/xen/lowlevel/xs/xs.c +++ b/tools/python/xen/lowlevel/xs/xs.c @@ -272,11 +272,12 @@ static PyObject *xspy_get_permissions(XsHandle *self, PyObject *args) if (perms) { PyObject *val = PyList_New(perms_n); - for (i = 0; i < perms_n; i++, perms++) { - PyObject *p = Py_BuildValue("{s:i,s:i,s:i}", - "dom", perms->id, - "read", perms->perms & XS_PERM_READ, - "write",perms->perms & XS_PERM_WRITE); + for (i = 0; i < perms_n; i++) { + PyObject *p = + Py_BuildValue("{s:i,s:i,s:i}", + "dom", perms[i].id, + "read", perms[i].perms & XS_PERM_READ, + "write", perms[i].perms & XS_PERM_WRITE); PyList_SetItem(val, i, p); } -- 2.30.2